Skip to content

Add guidance for restore and initial load - #6945

Merged
julienmarcbrown merged 10 commits into
developfrom
dev/pe/dump-restore
Oct 15, 2025
Merged

julienmarcbrown merged 10 commits into
developfrom
dev/pe/dump-restore

Conversation

@eatonphil

Copy link
Copy Markdown
Contributor

No description provided.

@eatonphil
eatonphil requested a review from a team as a code owner August 20, 2025 00:03
Comment thread product_docs/docs/pgd/6/reference/backup-restore.mdx Outdated
@eatonphil
eatonphil force-pushed the dev/pe/dump-restore branch from 49c8e7a to 4b8237e Compare August 28, 2025 23:55

@irionr irionr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

Comment thread product_docs/docs/pgd/6.1/reference/backup-restore.mdx Outdated
Comment thread product_docs/docs/pgd/6.1/reference/backup-restore.mdx Outdated
Comment thread product_docs/docs/pgd/6.1/reference/backup-restore.mdx
Comment thread product_docs/docs/pgd/6.1/reference/backup-restore.mdx Outdated
Comment thread product_docs/docs/pgd/6.1/reference/backup-restore.mdx
@eatonphil

Copy link
Copy Markdown
Contributor Author

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

I don't understand what you mean here sorry

@irionr

irionr commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

I don't understand what you mean here sorry

This is minor. I meant we should first tell them how to configure the nodes, and only after that, to show them the dump and restore commands. Also, I would temporarily adjust these settings even if they use the "pre/data/post" method.
It's only a cosmetic thing probably , but users will just start reading and copying/running the commands before reaching the configuration point.

@eatonphil

Copy link
Copy Markdown
Contributor Author

Wait don't merge this one yet please @julienmarcbrown

@eatonphil

Copy link
Copy Markdown
Contributor Author

This is minor. I meant we should first tell them how to configure the nodes, and only after that, to show them the dump and restore commands. Also, I would temporarily adjust these settings even if they use the "pre/data/post" method.
It's only a cosmetic thing probably , but users will just start reading and copying/running the commands before reaching the configuration point.

No this is a good point, modified.

@eatonphil

Copy link
Copy Markdown
Contributor Author

I've addressed all PR feedback on the PGD side now @julienmarcbrown , good for a final docs review.

@julienmarcbrown
julienmarcbrown merged commit 10e5c9c into develop Oct 15, 2025
7 checks passed
@julienmarcbrown
julienmarcbrown deleted the dev/pe/dump-restore branch October 15, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants