Conversation
Member
|
Er, I would like to keep the behavior of being able to override the enzyme
autodiff in these cases.
I think the correct answer here is perhaps to leverage the abstract
interpreter stuff but I’m more quite sure how to use it here
…On Sun, Jul 7, 2024 at 5:15 PM Sergio Sánchez Ramírez < ***@***.***> wrote:
@mofeing <https://github.com/mofeing> requested your review on: #37
<#37> Remove Cassette.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXCLXBKYJYJB2J7L4KLZLGVXVAVCNFSM6AAAAABKPVSJ5KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGQYTIOJYG43DIMI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Collaborator
Author
|
@jumerckx is working in something similar for upstream MLIR.jl JuliaLLVM/MLIR.jl#77 Maybe we can implement some simplified version of this. |
Member
|
@mofeing I think emulating this is the right solution https://github.com/JuliaGPU/GPUCompiler.jl/pull/582/files cc @vchuravy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I seen in the code, Cassette's contextual dispatch is only needed for overriding
Enzyme.autodiff. But Cassette has a very high overhead that kills performance. I have started to see very high compile times in some local examples.This PR tries to remove Cassette from the equation by defining a new
autodifffunction (Reactant.autodiff). This might not be the best solution, but it's an idea I want to experiment with.