Skip to content

chore: remove sismo data fetching task and related dependencies - #5

Merged
Euler-B merged 1 commit into
mainfrom
feature/remove-sismo-fetch-task
Aug 5, 2026
Merged

chore: remove sismo data fetching task and related dependencies#5
Euler-B merged 1 commit into
mainfrom
feature/remove-sismo-fetch-task

Conversation

@Euler-B

@Euler-B Euler-B commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Changed
    • Seismic data ingestion is now handled by the separate Telurify Ingestion service instead of the application’s local data-loading process.
    • Removed the local seismic data-fetching workflow and its associated dependencies.
  • Documentation
    • Updated the architecture overview and component responsibilities to reflect the external ingestion service.
    • Removed outdated instructions for loading seismic data locally and clarified the distinction between the ingestion service and the USGS source.

@Euler-B Euler-B self-assigned this Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The internal sismo:fetch_data rake task and its httparty and csv dependencies were removed. README architecture, data flow, setup instructions, and external service descriptions now reference Telurify Ingestion.

Changes

Seismic ingestion boundary

Layer / File(s) Summary
Remove internal ingestion task
lib/tasks/fetch_sismo_data.rake, Gemfile
The sismo:fetch_data task and its USGS fetching, validation, persistence, and reporting logic were removed. The httparty and csv dependencies were removed.
Update architecture and setup documentation
README.md, .coderabbit.yaml
Documentation now identifies Telurify Ingestion as the ingestion service and removes the local rake-task instructions. Review guidance no longer lists httparty as a key dependency.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the removal of the sismo data fetching task and its related dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/remove-sismo-fetch-task

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
README.md (1)

90-90: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Document the local data-loading workflow.

After make dev-setup, the README no longer explains how to populate sismos. The external ingestion service requires a separate database configuration and ingestion command. (github.com)

Add a short section that links to the ingestion service's local execution instructions, or state explicitly that local data loading is out of scope.

📄 Proposed documentation update
+### Load seismic data locally
+
+After `make dev-setup`, run the [Telurify Ingestion local execution instructions](https://github.com/Euler-B/Telurify-Ingestion#local-execution) against the development PostgreSQL database.
+
 ### Access the apps
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 90, Update the README near “Access the apps” to document
the local sismos data-loading workflow after make dev-setup, linking to
Telurify-Ingestion’s local execution instructions and noting its separate
database configuration; alternatively state clearly that local data loading is
out of scope.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@README.md`:
- Line 90: Update the README near “Access the apps” to document the local sismos
data-loading workflow after make dev-setup, linking to Telurify-Ingestion’s
local execution instructions and noting its separate database configuration;
alternatively state clearly that local data loading is out of scope.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4b492de7-44c0-44c8-91d9-91a69841968f

📥 Commits

Reviewing files that changed from the base of the PR and between 71d81b4 and 78b773b.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock, !Gemfile.lock
📒 Files selected for processing (4)
  • .coderabbit.yaml
  • Gemfile
  • README.md
  • lib/tasks/fetch_sismo_data.rake
💤 Files with no reviewable changes (2)
  • lib/tasks/fetch_sismo_data.rake
  • Gemfile

@Euler-B
Euler-B merged commit ee003ad into main Aug 5, 2026
3 checks passed
@Euler-B
Euler-B deleted the feature/remove-sismo-fetch-task branch August 5, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant