Fix RTF shape crop property mapping#82
Draft
vixco wants to merge 1 commit into
Draft
Conversation
Signed-off-by: vixco <93612321+vixco@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cropFromLefttom_nCropFromLeft.cropFromRighttom_nCropFromRight.Why
The RTF shape property reader had two copy/paste assignments in the picture crop block:
cropFromLeftwas stored inm_nCropFromRight.cropFromRightwas stored inm_nCropFromTop.This can make imported RTF picture cropping use the wrong side. The assignments now match the field names, the RTF shape serializer, and the OOXML/MS binary crop readers in this repository.
Validation
git diff --check.RtfShapecrop field definitions.RtfShapeRTF serialization for the same crop properties.