Repository navigation
Conversation
Contributor
|
srilman
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Use
Option<i64>for SQLread_icebergsnapshot IDs and both scan-builder configurations, following the signedness decision in #7477. This removes pointer-width dependence and lets absent negative IDs reach Iceberg's snapshot lookup instead of failing unsigned-option parsing. Other unsigned table-function options retain their existing validation.Add deterministic SQL/Python parity tests for IDs above the 32-bit range and at
i64::MAX, negative missing-snapshot diagnostics, and invalid literal rejection. Document the ID type. The general SQL number parser is unchanged, including its existing exact-i64::MINliteral limitation.Validation on macOS ARM64:
cargo check -p daft-sql -p daft-logical-plan --no-default-featurespassed.cargo fmt --all -- --check, pinned Ruff 0.14.10 lint/format on the changed Python file, andgit diff --checkpassed.The native build used a local
-C strip=noneworkaround for macOS linker output rejection; no build configuration changes are included. No 32-bit, Ray or full-workspace CI run was performed locally.AI disclosure: Codex generated the implementation and regression tests, reviewed the diff, and ran the baseline and post-fix checks above. A second agent independently reviewed the patch; test results described here are agent-run validation.
Related Issues
Closes #7477.