Support phone-based model inference for StyleTTS2 - #868
Merged
Conversation
Changed Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 85.22% 85.44% +0.22%
==========================================
Files 51 51
Lines 4710 4782 +72
Branches 700 710 +10
==========================================
+ Hits 4014 4086 +72
+ Misses 535 525 -10
- Partials 161 171 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
joanise
reviewed
Aug 28, 2026
joanise
approved these changes
Aug 28, 2026
joanise
left a comment
Member
There was a problem hiding this comment.
Looks good to me (once CI passes).
add target text representation and chunking to styletts2
roedoejet
force-pushed
the
dev.ap/phone-based-models
branch
from
August 28, 2026 22:41
b7a9fea to
aadab4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
When I tested the demo, I only tested it with character based models, but this was only less than half of the issue. For inference with phone-based models we needed to follow the FS2 implementation which is:
Development was assisted with Claude Code Sonnet 5, reviewed by me.
Feedback sought?
code review/sanity - is there anything else I'm forgetting here wrt things that are needed for inference?
Priority?
before 0.5.0. :)
Confidence?
medium-high (tested with my pre-trained checkpoints)
Version change?
Related PRs?
EveryVoiceTTS/StyleTTS2#27