Conversation
MrAxxy
commented
Aug 12, 2026
MrAxxy
commented
Contributor
- add filter expression evaluator to GUI
- filter is selectable for all expression properties and configured through the existing SearchFilterConfigurationPanel.
- condition editor now offers Script and Filter instead of the script editor only.
skublik
requested changes
Aug 12, 2026
skublik
left a comment
skublik
left a comment
Contributor
There was a problem hiding this comment.
I know we don’t have much Javadoc in the code, and I’m struggling with it myself, but if you’re adding a new method that’s public, add Javadoc for it (ExpressionUtil)
- sdd filter expression evaluator to GUI - filter is selectable for all expression properties and configured through the existing SearchFilterConfigurationPanel. - condition editor now offers Script and Filter instead of the script editor only.
Contributor
Author
Understood, Javadoc added. |
skublik
approved these changes
Aug 13, 2026
- write the filter into the expression even when the condition is still empty, LambdaModel skips its setter on a null target - update the filter field on blur, panels closing with a plain ajax link never submit the form and dropped the typed filter - set outputMarkupId on SearchFilterConfigurationPanel, it re-renders itself when switching between XML and query - style the filter buttons as btn-light border, btn-primary is reserved for primary actions
Contributor
Author
|
I discovered some bugs during implementation of better handling of conditions in GUI. @skublik please review them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.