Sidebar prototype - #832
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes, primarily focused on patient triage validation and session handling. The most significant changes include enforcing that birth dates cannot be set in the future (both client-side and server-side), improving error handling and user feedback in the triage workflow, refactoring session management for better testability, and adding new font resources for UI consistency.
Patient Triage Validation and Error Handling:
TriageControllerso that if validation (such as an invalid birth date) fails, the form is re-rendered with a helpful error message and all necessary data repopulated.index.scala.html) to set the maximum allowed birth date to today's date, preventing future dates from being selected via the UI.triageClientValidation.jsto check that the entered birth date is not in the future, providing immediate feedback before form submission.Session Handling Refactor:
ISessionContextinterface and its Play Framework-based implementation (PlaySessionContext), and refactoredSessionHelperto use dependency injection for session access. This change improves testability and decouples session logic from the Play framework. [1] [2] [3] [4] [5]Other Improvements:
TriageControllerfor clarity.