Update axios and lodash to address newly reported vulnerabilities#1621
Merged
Conversation
- Bump axios from ^1.13.2 to ^1.15.0 to patch GHSA-fvcv-3m26-pcqx (unrestricted cloud metadata exfiltration via header injection) and GHSA-3p68-rc4w-qgx5 (NO_PROXY hostname normalization bypass leading to SSRF). - Bump lodash from ^4.17.21 to ^4.17.24 to patch GHSA-r5fr-rjxr-66jc (code injection via _.template) and GHSA-f23m-r3pf-42rh (prototype pollution via array path bypass in _.unset and _.omit). - Add an explicit overrides entry for follow-redirects ^1.15.12 to clear GHSA-r4q5-vmmm-2653 (custom authentication headers leaked to cross-domain redirect targets). axios 1.15.0 still pins follow-redirects@1.15.11, which is the upper bound of the vulnerable range; the override pulls in 1.16.0. npm audit now reports 0 vulnerabilities. All unit tests, lint, and prettier checks pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cmoesel
approved these changes
Apr 16, 2026
cmoesel
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution. I'm not sure the overrides entry is needed, as npm audit fix took care of follow-redirects for me -- but we'll take it as-is and remove it if it turns out it's not necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditon the currentmasterreports three advisories against thedirect
axiosandlodashdependencies (plusfollow-redirectstransitivelythrough
axios). All three were published after SUSHI 3.18.1 was cut, sothey are not covered by the resolution in #1611. This PR bumps the affected
direct dependencies to their first non-vulnerable versions and adds an
overridesentry forfollow-redirects, becauseaxios@1.15.0still pinsfollow-redirects@1.15.11— the upper bound of the vulnerable range.axios^1.13.2^1.15.0axios^1.13.2^1.15.0NO_PROXYbypass → SSRFlodash^4.17.21^4.17.24_.templatelodash^4.17.21^4.17.24_.unset/_.omitfollow-redirects1.15.111.16.0`lodash` was bumped to `^4.17.24` (rather than the latest `^4.18.x`) as the
minimal-change floor that stays within the existing `4.17` caret range — npm
still resolves to the latest 4.x at install time (currently 4.18.1). This
matches the spirit of `DEPENDENCY-NOTES.md`, which prefers the smallest
effective bump.
Related: #1611 (the earlier post-3.17.0 transitive-vulnerability sweep, which
was resolved for 3.18.1).
Test plan