Implement support for true/false permission requirements in FancyDialog - #311
Open
Furqit wants to merge 1 commit into
Open
Implement support for true/false permission requirements in FancyDialog#311Furqit wants to merge 1 commit into
Furqit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
This PR adds support for configuring the expected value of a
permissionrequirement in FancyDialog.Previously, permission requirements always checked whether the player had the specified permission. This change adds an optional
valuefield, allowing requirements to check whether a player has or does not have a permission.If
valueis not specified, it defaults totrue, preserving the existing behavior.🔍 Changes
valuefield topermissionrequirementsvalue: truerequires the player to have the permissionvalue: falserequires the player to not have the permissiontruewhenvalueis not specified🧪 How to Test
permissionrequirement without specifyingvalue.value: trueand verify it still passes when the player has the permission.value: falseand verify it passes when the player does not have the permission.value: falsefails when the player does have the permission.