add cpu sampling feature - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bb12754. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches the event-loop hot path and starts a process-wide daemon plus at-fork reinit. Overhead is designed to be tiny, but sampling is on by default and uses sys._current_frames().
Overview
CPU-bound slow tasks now get stack attribution, matching what IO events already have from audit hooks.
A daemon watchdog samples the loop thread after an arming delay (default: half the slow-task threshold) and attaches aggregated stacks with counts to
SlowTaskEvent.cpu_stack_samples.detect_slow_tasks()starts this automatically (cpu_sampling=Falseto opt out); callstart_cpu_sampling()first to customize interval, arm delay, idle wake-up, and sample cap.Sampling follows the thread that published the slice (not only main), restarts after
fork()for gunicorn--preload, filters aiocop frames, and floors sleep at 1ms so config cannot busy-loop. GIL-holding C calls still starve the sampler — few samples on a long slice is treated as a signal.Reviewed by Cursor Bugbot for commit f31c3d6. Bugbot is set up for automated code reviews on this repo. Configure here.