Adopt section-pull-requests 0.4.0, and fix what blocked a fresh clone - #6
Open
AndreaSucreG wants to merge 1 commit into
Open
Adopt section-pull-requests 0.4.0, and fix what blocked a fresh clone#6AndreaSucreG wants to merge 1 commit into
AndreaSucreG wants to merge 1 commit into
Conversation
The template pinned `@asucregonzalez/ui` at `^0.3.0` while npm had only 0.2.0 published, so `pnpm install` failed with ERR_PNPM_NO_MATCHING_VERSION. That version is now published; repinned alongside section-pull-requests 0.4.0 and section-tasks 0.3.0. 0.4.0 brings stacked-PR chains, Jira stream attribution, scheduled checkpoint posting and an author filter. Two things it needs from the host: - Jira's three env vars, which were declared nowhere. Documented in .env.example as opt-in — attribution degrades to "unattributed" rather than failing. - `defaultOrganizations`. The GitHub org used to be hardcoded in the package, so an install queried someone else's org and returned their PRs, or none. It now ships empty and the host names its own, from VITE_GITHUB_ORGS. One variable read by both server and client, so the org the settings UI suggests cannot drift from the org the server queries. Unset is safe: a fetch reports "no organizations configured" instead of rendering an empty list that reads as a quiet queue. Two guide bugs, both self-inflicted: - The Setup card told users to run `make claude`. No such target exists — it is `make run`, which the README already said. - The drift check that is supposed to catch an undocumented section was itself drifting. Its card claimed the `guide` GROUP id while the check reads the flattened LEAF list, so the card never rendered and setup/how-to/faq were reported undocumented on every load. A card can claim several ids now. Also corrects the overview table, which omitted the Guide tab and the Claude sessions panel, and the skill count. Verified: `pnpm install` resolves, `tsc --noEmit && vite build` passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pnpm installon a fresh clone fails today:@asucregonzalez/uiis pinned^0.3.0but npm only had 0.2.0 published, so the template dies withERR_PNPM_NO_MATCHING_VERSION. That version is now on npm.Repinned to the three versions published today:
section-pull-requests^0.3.0^0.4.0section-tasks^0.2.0^0.3.0ui^0.2.0^0.3.0What 0.4.0 brings
Stacked-PR chains, Jira stream attribution, scheduled checkpoint posting, and an author filter on the "mine" views. Two things it needs from the host app:
Jira's three env vars were declared nowhere. Now in
.env.example, documented as opt-in — without them attribution degrades to "unattributed" rather than failing.defaultOrganizations. The GitHub org used to be hardcoded inside the published package, which meant an install queried someone else's org and returned their PRs, or none — a failure that looks like success. The package now ships empty and the host names its own, read fromVITE_GITHUB_ORGS. One variable for both server and client, so the org the settings UI suggests cannot drift from the org the server actually queries. Leaving it unset is safe: a fetch reports "no organizations configured" instead of rendering an empty list that reads as a quiet queue.Two guide bugs
make claude. No such target exists — it'smake run, which the README already said correctly.guidegroup id while the check reads the flattened leaf list, so the card never rendered andsetup/how-to/faqwere reported undocumented on every load. A card can claim several ids now.Also corrects the overview table (it omitted the Guide tab and the Claude sessions panel, and still described Day as an empty page) and the skill count.
Verification
pnpm installresolves all ten@asucregonzalez/*pinstsc --noEmit && vite buildpassesClaims in the docs were checked against this repo rather than copied from upstream — the Day row drops the "Run morning sync" button and
refreshEnabledstaysfalse, since this app mounts no/api/refreshroute.🤖 Generated with Claude Code
Note
Low Risk
Mostly dependency bumps, env wiring, and documentation; PR routing behavior changes are configuration-driven with safe fallbacks when vars are unset.
Overview
Upgrades
section-pull-requests,section-tasks, anduiso a freshpnpm installresolves (the UI pin had been ahead of what was on npm). That unlocks PR section 0.4.0 behavior in the host app.GitHub orgs are no longer implied by the package:
VITE_GITHUB_ORGSis documented in.env.exampleand parsed in bothsrc/App.tsx(defaultOrganizationsfor the UI) andserver/index.ts(same list passed intoregisterPullRequestsRoutes), so suggested orgs and API queries stay aligned; unset orgs surface an explicit message instead of a silent empty queue.Optional Jira env vars (
JIRA_BASE_URL,JIRA_EMAIL,JIRA_API_TOKEN) are added to.env.examplefor stream attribution without breaking the PR list when omitted.Docs and Guide fixes: README reflects Today / Archives / Guide navigation and current tabs; Guide Setup card uses
make runinstead ofmake claude; Guide cards can claim multiple section ids, and the Guide card now mapssetup,how-to, andfaqso the “undocumented sections” check stops false-alarming.Reviewed by Cursor Bugbot for commit 075c2d1. Bugbot is set up for automated code reviews on this repo. Configure here.