fix(metrics): collect wallet balance only from the api pod - #668
Open
silent-cipher wants to merge 2 commits into
Open
fix(metrics): collect wallet balance only from the api pod#668silent-cipher wants to merge 2 commits into
silent-cipher wants to merge 2 commits into
Conversation
silent-cipher
force-pushed
the
fix/api-only-wallet-balance-collector
branch
from
July 29, 2026 09:49
b2d7857 to
19e55d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WalletBalanceCollectorout of the shared metrics moduleRationale
Wallet balance is shared external state rather than process-local state. Collection if from every API and worker pod creates duplicate series, increases rpc traffic, and can produce misleading results when the metrics is aggregated.
The deployment runs a single api replica, so the api pod is the appropriate owner of this collector.