Conversation
- Run the build on pull requests, on demand (workflow_dispatch), and weekly (in addition to release tags), and split the workflow into a build job (runs every trigger) and a release job (tag-only), so PRs get validated without requiring a release build. - Add tests/check_assets.py: validates amiibo.dat identifiers, cross- checks game name/mapping files (including Switch 2) against each other and against amiibo.dat, and runs as part of the build job. - Document the `App: 87, FW: 88`-style SDK/firmware mismatch error and what causes it, plus a note that a firmware fork adding fields to shared NFC structs can make a mismatched build corrupt data silently instead of refusing to launch. - Clarify key_retail.bin's exact size/format requirement and that a malformed key never gets logged or used to produce invalid data. - Ignore local uFBT SDK/venv caches, .DS_Store, and a temp-files/ folder intended for local NFC dumps and key material that should never be committed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatch), and weekly (in addition to release tags), and splits the workflow into abuildjob (runs on every trigger) and areleasejob (tag-only), so PRs get validated without requiring a release build.tests/check_assets.py: validatesamiibo.datidentifiers, cross-checks game name/mapping files (including Switch 2) against each other and againstamiibo.dat, and runs it as part of thebuildjob.App: 87, FW: 88-style SDK/firmware mismatch error and what causes it, plus a note that a firmware fork adding fields to shared NFC structs can make a mismatched build corrupt data silently instead of refusing to launch (found this the hard way while debugging on a custom firmware fork - see PR docs: improve README #2 in this batch for the actual fix).key_retail.bin's exact size/format requirement and that a malformed key is never logged or used to produce invalid data..DS_Store, and atemp-files/folder intended for local NFC dumps and key material that should never be committed.Test plan
python3 tests/check_assets.pypasses against the currentfiles/assetsufbtbuild succeeds against the official release SDK (API 88.x)🤖 Generated with Claude Code