release(action): 3.7.3 on core 6.19.4 (GHSA-fpvw-w7ff-h7vr) - #317
Merged
Conversation
The committed ncc bundle was last rebuilt in fcd8e8d, before the ReDoS fix landed in core 6.19.4, so the action still shipped the vulnerable UnusedVariable rule to every consumer. Rebuild dist against the fixed core. Verified: the bundle now contains countLiteralOccurrences and no longer contains new RegExp(variableName, "gi") or new RegExp(variable.name, "gi").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core
6.19.4and CLI6.19.5shipped the ReDoS fix for GHSA-fpvw-w7ff-h7vr (43cd554). The GitHub Action did not.packages/actionships a committednccbundle whosedistwas last rebuilt in fcd8e8d — before the fix — so every consumer ofFlow-Scanner/lightning-flow-scanner@main(the usage documented in the README) has been running the vulnerableUnusedVariablerule.What
packages/action3.7.2 → 3.7.3dist/index.js+dist/index.js.maprebuilt against core 6.19.4Verification
Not trusting the version number — checked the built output directly:
countLiteralOccurrencesindist/index.jsnew RegExp(variableName, "gi")new RegExp(variable.name, "gi")The bundled function body is byte-identical to the fixed source.
pnpm test -- UnusedVariableinpackages/core: 10 passed, 3 suites, includingUnusedVariable.security.test.ts.