Skip to content

fixed some warnings from compiler - #5

Open
burlito wants to merge 3 commits into
FluXy:masterfrom
burlito:master
Open

fixed some warnings from compiler#5
burlito wants to merge 3 commits into
FluXy:masterfrom
burlito:master

Conversation

@burlito

@burlito burlito commented Oct 23, 2013

Copy link
Copy Markdown

No description provided.

@tristanheaven

Copy link
Copy Markdown
Collaborator

This would break _DEBUG builds.

@burlito

burlito commented Oct 23, 2013

Copy link
Copy Markdown
Author

I'm so sorry, I will fix this asap.

@burlito

burlito commented Oct 23, 2013

Copy link
Copy Markdown
Author

Ok, I belive it will work ok now.

Conflicts:
	smc/src/core/i18n.cpp
@datahead8888

Copy link
Copy Markdown

@tristanheaven or @Quintus - were we able to make use of this patch (or have we already put it to use)? I just was wondering.

@burlito - as I said in another reply - you are welcome to join our team at https://github.com/Secretchronicles/TSC. We are getting close to a new release of the game.

@Quintus

Quintus commented Oct 3, 2014

Copy link
Copy Markdown

The patch will not apply to the TSC sourcecode anymore, plus I don’t think simply casting to the unsigned value is the correct way of resolving the compiler warnings. The logic must be fixed, i.e. the variable in quesiton must be unsigned right from the beginning.

Vale,
Quintus

@burlito

burlito commented Oct 3, 2014

Copy link
Copy Markdown
Author

Hi,

Actually this wariabile was in first place signes, there was a some
reason why I changed that and recast in other place. however I'm not
sure why.

On 10/03/2014 03:40 AM, Marvin Gülker wrote:

The patch will not apply to the TSC sourcecode anymore, plus I don’t
think simply casting to the unsigned value is the correct way of
resolving the compiler warnings. The logic must be fixed, i.e. the
variable in quesiton must be unsigned right from the beginning.

Vale,
Quintus


Reply to this email directly or view it on GitHub
#5 (comment).

Kind regards,
b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants