Skip to content

Skip visit geocoding when no provider is configured - #3255

Draft
Rivbla wants to merge 1 commit into
Freika:masterfrom
Rivbla:agent/skip-visit-geocoder-without-provider
Draft

Skip visit geocoding when no provider is configured#3255
Rivbla wants to merge 1 commit into
Freika:masterfrom
Rivbla:agent/skip-visit-geocoder-without-provider

Conversation

@Rivbla

@Rivbla Rivbla commented Jul 29, 2026

Copy link
Copy Markdown

Summary

Skip visit-name geocoder requests when no reverse-geocoding provider is configured.

Geocoder otherwise falls back to its default Nominatim lookup even though DawarichSettings.reverse_geocoding_enabled? is false. During visit detection this adds the full provider timeout to every detected place.

Configured-provider behavior is unchanged.

Validation

  • focused RSpec: 4 examples, 0 failures
  • RuboCop: 2 files, 0 offenses
  • Ruby syntax checks
  • regression check: disabled configuration performs 0 searches; enabled configuration performs 1 search with the original arguments

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2316b968-ce73-495b-9c4e-2ccbeaa87476

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant