feat(docker): Add multi-platform support for Docker build - #541
Conversation
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit d9ed7c5. Bugbot is set up for automated code reviews on this repo. Configure here. |
Migrate docker-publish to FuelLabs/github-actions docker-build-push with build-backend native and linux/amd64,linux/arm64 on native runners. Refs DEVOPS-1248 Co-authored-by: Cursor <cursoragent@cursor.com>
3d168e2 to
32b28ca
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The workflow now calls FuelLabs/github-actions docker-build-push; the composite under .github/actions/docker-publish had no remaining references. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4b3918. Configure here.
|
Reviewed Bugbot's 4 findings on this PR — all anchored to commits ( |
docker-build-push.yml's jobs unconditionally request id-token: write at the job level; a reusable-workflow caller that doesn't grant it caps that scope down regardless of what the nested job asks for. This repo's auth-mode (registry-login) + build-backend native's digest-push path (provenance: false) don't appear to actually need an OIDC token today, but every other FuelLabs repo on this same migration grants it defensively (prometheus-exporter, fuel-mcp-server, sway-playground, faucet, ...) and this workflow has no pull_request trigger, so it's never actually exercised by PR CI to prove otherwise. Match the established pattern rather than rely on that argument. Flagged by Cursor Bugbot.
|
Correction to my earlier comment: I lumped this finding in with the other 3 as "stale," but its `original_commit_id` is `e4b3918` — the actual HEAD, not a superseded intermediate commit. That was my mistake, not bugbot's. On the substance: `auth-mode: registry-login` skips the OIDC/ECR-login steps in the shared composite entirely, and `build-backend: native` always hits the digest-push variant, which sets `provenance: false` — so nothing in the actual execution path calls for an OIDC token today. But I can't verify that by watching it run: this workflow has no `pull_request` trigger, so it's never exercised by this PR's CI. Every other repo on this migration using `registry-login` (prometheus-exporter, fuel-mcp-server, sway-playground, faucet) grants `id-token: write` anyway and all built green — this was the one outlier. Added it to match, rather than lean on an argument I can't test. |

No description provided.