Repository navigation
optimize pget_db_query by allowing field filter #5372
Description
User Story
In order to reduce data requested from the h20 db, datagov wants to update the pget_db_query db interface function to support specific fields
Acceptance Criteria
[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]
- GIVEN the pget_db_query function
WHEN a list of field strings is used as input
THEN only those fields from the model will be returned in the output
Background
- working on #5358 I discovered that
pget_db_queryreturns all model fields which we don't need when we're clearing out records (we only need record identifiers and the harvest source)
Security Considerations (required)
[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]
Sketch
- i got ahead and made this solution for #5358 but it isn't needed. here's how i did it...
def get_model_fields_by_filter(self, model, fields_filter=None):
"""
return all Columns from the model or just those in fields_filter
"""
if fields_filter is None:
field_names = [field.name for field in model.__table__.columns]
else:
field_names = [
field.name
for field in model.__table__.columns
if field.name in fields_filter
]
return [getattr(model, field) for field in field_names]
#...
def pget_db_query(self, model=None, facets="", order_by="asc", **kwargs):
#...
model_data = self.get_model_fields_by_filter(
model_name, kwargs.get("fields_filter")
)
return (
self.db.query(model_name)
.options(load_only(*model_data))
.filter(text(facet_string))
.order_by(order_by_val)
)[Notes or a checklist reflecting our understanding of the selected approach]
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
2 remaining items