Repository navigation
Update cloudgov cli action tools - #55
Merged
Merged
Conversation
jbrown-xentity
previously approved these changes
Jun 30, 2026
jbrown-xentity
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Some other possible improvements could be made in this PR or as a follow up.
rshewitt
dismissed
jbrown-xentity’s stale review
June 30, 2026 20:36
need to update to properly handle private/internal addresses
rshewitt
force-pushed
the
update-cloudgov-cli-action-tools
branch
from
June 30, 2026 21:01
0fa9395 to
00c2fcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to 5020
testing this out on dev space i sent the following request
as you see in the picture
real_ipis 203.0.113.42 despite putting loopback as the first forwarded ip address. forwarded ip addresses look like this in new relic203.0.113.42, 198.51.100.10, 2601:283:4404:9ee0:2cf9:daae:b3fc:9fab, 64.252.71.222, 127.0.0.1needed to update the private ip address handling code (wasn't working as intended)