Skip to content

Update cloudgov cli action tools - #55

Merged
rshewitt merged 4 commits into
mainfrom
update-cloudgov-cli-action-tools
Jun 30, 2026
Merged

rshewitt merged 4 commits into
mainfrom
update-cloudgov-cli-action-tools

Conversation

@rshewitt

@rshewitt rshewitt commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

related to 5020

  • draining apps failed using pinned version of cg-cli-tools. deployment on dev space worked using main branch instead.

testing this out on dev space i sent the following request

MARK="xff-grok-test-$(date -u +%Y%m%dT%H%M%SZ)" # look for "xff-grok-test-20260630T195038Z"

curl -v \
  -u 'USERNAME:PASSWORD' \
  -H "User-Agent: ${MARK}" \
  -H 'X-Forwarded-For: 127.0.0.1, 203.0.113.42, 198.51.100.10' \
  -H 'Cache-Control: no-cache' \
  "https://catalog-dev.data.gov/?xff_test=${MARK}"

as you see in the picture real_ip is 203.0.113.42 despite putting loopback as the first forwarded ip address. forwarded ip addresses look like this in new relic

203.0.113.42, 198.51.100.10, 2601:283:4404:9ee0:2cf9:daae:b3fc:9fab, 64.252.71.222, 127.0.0.1

needed to update the private ip address handling code (wasn't working as intended)

Screenshot 2026-06-30 at 1 55 49 PM

@rshewitt
rshewitt requested a review from a team June 30, 2026 20:04
jbrown-xentity
jbrown-xentity previously approved these changes Jun 30, 2026

@jbrown-xentity jbrown-xentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some other possible improvements could be made in this PR or as a follow up.

Comment thread .github/workflows/deploy.yml Outdated
@rshewitt
rshewitt dismissed jbrown-xentity’s stale review June 30, 2026 20:36

need to update to properly handle private/internal addresses

@rshewitt
rshewitt force-pushed the update-cloudgov-cli-action-tools branch from 0fa9395 to 00c2fcb Compare June 30, 2026 21:01
@rshewitt
rshewitt requested a review from jbrown-xentity June 30, 2026 21:03

@jbrown-xentity jbrown-xentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rshewitt
rshewitt merged commit 1fe3797 into main Jun 30, 2026
4 checks passed
@rshewitt
rshewitt deleted the update-cloudgov-cli-action-tools branch June 30, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants