Repository navigation
Keep a user's proxy exemptions, warn when loopback would reach a proxy, and stop everything before a rerun - #279
Merged
Conversation
… the Guardian cannot Signed-off-by: rocklambros <rock@rockcyber.com>
… proxy exemptions Signed-off-by: rocklambros <rock@rockcyber.com>
rocklambros
requested review from
GangGreenTemperTatum,
afogel,
artmaro,
bar-capsule,
fewdisc,
mamicidal and
sclintonowasp
as code owners
October 15, 2026 18:00
Collaborator
Author
|
Admin-merged on the project lead's call to land Bar's two pre-handoff fixes from issue #274 before the 0.1.4 release. Every check is green, and the PR description has the test and end-to-end evidence. @afogel @bar-capsule, a look after the fact is still welcome, and anything you find goes in a follow-up. |
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This fixes the two problems Bar found in her review of PR #277 and marked as needed before the lab handoff. Both are in the trace walkthrough and the Guardian's trace exporter.
The first is that "Run it again" told readers to delete
.acswithout stopping anything first. A collector or Guardian that is still running keeps writing into the deleted file, so every later span disappears without an error. The paragraph now says to stop both first, and the Docker command names its container (acs-otelcol) sodocker stop acs-otelcolworks.The second is that
keepLoopbackOffProxycould switch off a user's existing proxy exemptions. It created whichever ofNO_PROXYandno_proxywas missing, and Bun 1.3.14 reads a non-emptyno_proxybeforeNO_PROXY. So a user with onlyNO_PROXY=corp.internallost that exemption. It now appends only to the variables the user set, using Bun's own rule for "set", and writes IPv6 loopback in the bracketed form Bun matches.Checking that fix turned up something bigger. Bun 1.3.11, which CI runs, reads the proxy variables only when the process starts, so the runtime edit does nothing there. The Guardian therefore also prints a warning at startup when a proxy is set and loopback isn't exempt, and the walkthrough's step 1 now exports both variables, keeping the reader's own entries. Those startup variables are what protect loopback on every Bun version.
Which issue does this implement
Refs #274
How it was checked
The spec and plan went through an adversarial premortem before any code was written. It ran two perspectives, and every finding was reproduced by running it.
bun test: 1230 pass on Bun 1.3.14, and 1229 pass with 2 skips on Bun 1.3.11.bun run typecheckis clean,bun run conformanceexits 0, anduv run pytestgives 918 passed.exportlines behave the same in bash and zsh, with the variables unset, set, set to different lists, empty, and underset -u.HTTP_PROXYandNO_PROXY=corp.internalset beforehand:corp.internal;Separately, the Claude Code shim has the same proxy exposure on its way to the Guardian. That predates this work, so the "Connect Claude Code" section now tells readers to start Claude Code with loopback exempt. The code fix belongs with the other issue #274 work.
Base branch
integration, because this touches the specification, schemas, a referenceimplementation, an adapter, tests, or CI
Type of change
I tested this
uv run pytest -vpasses on my machineChecklist
git commit -s(required by the DCO)Security
This narrows exposure. Spans to a loopback collector no longer lose a user's other proxy exemptions, a misconfigured proxy now produces a visible warning instead of a silent leak, and the walkthrough no longer loses spans on a rerun.