Repository navigation
Refuse a consumed or earlier-session approval presented again - #294
Open
astrogilda wants to merge 2 commits into
Open
astrogilda wants to merge 2 commits into
astrogilda wants to merge 2 commits into
Conversation
Section 10.3 defines a replay on the request: a duplicate request_id or nonce within the session. A one-time approval already consumed, or a grant from an earlier session, presented again in a fresh signed request is neither, so no section refused it and 17.1 had no code for it. Section 9.3 defines one-time, consumed and session-bound grants and requires a Guardian to refuse such an approval with REPLAY_CONSUMED, registered as -32009 because -32008 is proposed for a retryable overload code. Section 10.3 and the ACS-Core list point at the new section. Signed-off-by: Sankalp Gilda <23521054+astrogilda@users.noreply.github.com>
The section no longer touches the ACS-Core list, which is the Spec workstream's call for a later release. It says that v0.1 has no request field naming a grant, so the reuse rule is the half a wire test can observe, and that a second request presenting a one-time approval is refused even before the first decision returns. Signed-off-by: Sankalp Gilda <23521054+astrogilda@users.noreply.github.com>
astrogilda
requested review from
GangGreenTemperTatum,
fewdisc,
mamicidal,
rocklambros and
sclintonowasp
as code owners
October 17, 2026 15:11
astrogilda
requested review from
Lrd0036,
afogel,
almogbhl,
artmaro,
bar-capsule and
stefanoamorelli
as code owners
October 17, 2026 15:11
acs-board-reconciler
Bot
moved this from Needs triage
to In progress
in ACS Project Tracker
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@bar-capsule, @afogel, @rocklambros, this PR adds section 9.3 to the specification with the sentence proposed on #53:
Section 9.3 defines one-time, consumed and session-bound grants and registers REPLAY_CONSUMED in 17.1 as -32009, leaving -32008 to Discussion #257. ACS v0.1 has no request field that names a grant, so the testable half is reuse: an approved action sent again gets no approval. @avp9-nexus, -32009 is the 17.1 code for the two REPLAY_CONSUMED vectors on your negative-vectors-v0.2 branch.
Which issue does this implement
Part of #33; refs #53.
I tested this
At b564d10, the head of this branch, pytest gives 919 passed and the strict mkdocs build passes.