Repository navigation
fix: Optimize DNS resolution logic - #1143
Merged
Merged
Conversation
kgala2
approved these changes
Aug 11, 2026
hessjcg
changed the title
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-nodejs-connector
that referenced
this pull request
Aug 12, 2026
Updates the instance DNS name regex to the correct permissive format. See GoogleCloudPlatform/cloud-sql-go-connector#1143
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-jdbc-socket-factory
that referenced
this pull request
Aug 12, 2026
This PR addresses code review comments on PSC DNS error handling: Update IsInstanceDNSName regex to match /.sql(-\w+)?.goog$/ and exclude /.global.sql(-\w+)?.goog$/ Use specific error types/codes instead of checking error message strings for CNAME loops Disable periodic resolution for immutable instance DNS names Distinguish transient vs non-transient errors in monitored cache See GoogleCloudPlatform/cloud-sql-go-connector#1143
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the instance DNS name regex to the correct permissive format.