refactor(integration_tests): generalize WaitForSizeUpdate and rename wait constants to rapid - #5066
Conversation
vipnydav
added
the
execute-integration-tests-on-zb
github-actions
Bot
added
the
remind-reviewers
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the integration tests to support both zonal and pirlo bucket runs by updating the 'WaitForSizeUpdate' function to internally check the bucket type instead of requiring a boolean parameter. Additionally, the wait duration constants have been renamed from 'ZB' to 'Rapid'. The feedback suggests removing a redundant 'time.Duration' type conversion in 'reads_after_appends_test.go' to improve code readability.
5f1398e to
fbde38f
Compare
|
Hi @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
1 similar comment
|
Hi @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
fbde38f to
a55ad05
Compare
a55ad05 to
7e342ff
Compare
…wait constants to rapid
7e342ff to
230bcc9
Compare
|
Hi @meet2mky, @anushka567, @abhishek10004, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
1 similar comment
|
Hi @meet2mky, @anushka567, @abhishek10004, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
abhishek10004
left a comment
abhishek10004
left a comment
There was a problem hiding this comment.
LGTM. Left a minor comment.
2 participants
Description
WaitForSizeUpdateparameter name fromisZonal booltoisUnfinalized boolto represent unfinalized objects for both Zonal and Pirlo runs.WaitDurationAfterFlushZBWaitDurationAfterFlushRapidandWaitDurationAfterCloseZBWaitDurationAfterCloseRapidinfile_operations.go.file_operations.go, updatedCloseFiles,CloseFile, andCloseFileShouldNotThrowErrorto passsetup.IsZonalBucketRun()since only Zonal leaves files unfinalized on close (Pirlo finalizes on close by default and does not need to sleep 1s).storage_client.goandsymlink_suites_test.go, passedwc.Append && !wc.FinalizeOnCloseto dynamically wait only when an unfinalized appendable object was actually created.SyncFileinfile_operations.goandreads_after_appends_test.goto passsetup.IsZonalBucketRun() || setup.IsPirloBucketRun()for unfinalized flushes/appends.Testing details
Any backward incompatible change? If so, please explain.
NA