fix(config-reloader): bump reloader to the streaming version. - #2278
fix(config-reloader): bump reloader to the streaming version.#2278bwplotka wants to merge 2 commits into
Conversation
Context: b/483390013 Signed-off-by: bwplotka <bwplotka@google.com>
Signed-off-by: bwplotka <bwplotka@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.26.0 and upgrades multiple dependencies in go.mod and go.sum, including Kubernetes libraries, Prometheus components, and AWS SDKs. Feedback on the changes highlights an issue where the upgrade of github.com/prometheus/client_golang to v1.23.2 is negated by a replace directive pinning it to v1.23.0, which should be updated to match the upgraded version.
| // client_golang has to be pinned due to common pinning. | ||
| github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.23.0 |
There was a problem hiding this comment.
The replace directive pins github.com/prometheus/client_golang to v1.23.0, which overrides and negates the upgrade to v1.23.2 specified in the require block (line 21). To ensure the upgraded version is actually used, the replace directive should be updated to v1.23.2 (or removed if the pin is no longer necessary).
// client_golang has to be pinned due to common pinning.
github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.23.2
1 participant
Fixes: b/483390013
Pulls: thanos-io/thanos#9014
Benchmarks so far: