Modernize photo viewer#175
Merged
thestinger merged 19 commits intoJul 12, 2026
Merged
Conversation
inthewaves
suggested changes
Jul 3, 2026
inthewaves
suggested changes
Jul 3, 2026
m4pl
reviewed
Jul 3, 2026
RankoR
force-pushed
the
task/167-modernize-photo-viewer
branch
from
July 8, 2026 21:52
1269171 to
4d55024
Compare
inthewaves
suggested changes
Jul 10, 2026
Comment on lines
+233
to
+238
| @Composable | ||
| private fun PhotoViewerBlurredBackground( | ||
| dismissDragState: PhotoViewerDismissDragState, | ||
| items: ImmutableList<MediaPreviewItem>, | ||
| pagerState: PagerState, | ||
| ) { |
Member
There was a problem hiding this comment.
I think the blurred background could have a more smoother transition when switching:
Screen_recording_20260709_174113.mp4
Member
There was a problem hiding this comment.
see Google Messages for reference
RankoR
force-pushed
the
task/167-modernize-photo-viewer
branch
from
July 12, 2026 19:03
f6b06ec to
89cc882
Compare
RankoR
force-pushed
the
task/167-modernize-photo-viewer
branch
from
July 12, 2026 19:29
89cc882 to
ccd411e
Compare
Member
|
Contributor
Author
|
@inthewaves yep, there're also several other issues caused by rebase, fixing them now. Will re-request review when ready. |
inthewaves
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces legacy photo viewer with a modern one.