Fix crash when declining a call with a quick response#194
Merged
thestinger merged 1 commit intoJul 13, 2026
Conversation
RankoR
suggested changes
Jul 12, 2026
RankoR
left a comment
RankoR
left a comment
Contributor
There was a problem hiding this comment.
LGTM, But please add a regression test (we already have Robolectric in the project - you can use it).
Commit 9aec6f6 replaced the argument-less notification refresh with BugleNotifications.updateWithInlineReply(conversationId, message), which is also reached from the recipients-only RESPOND_VIA_MESSAGE path where conversationId is null. Telecom invokes this exported service whenever the user rejects an incoming call with a quick-response text, and the null conversationId crashes on the non-null channelId parameter of NotificationChannelUtil.getActiveNotification. Since the service sets intent redelivery, the crash also redelivers the intent and re-sends the reply, causing duplicate texts alongside the crash loop. Move the call into the branch where the conversation is known. The notification inline-reply path always supplies a conversation id, so its behavior is unchanged, and the recipients-only path has no active conversation notification to update in the first place.
thomasbuilds
force-pushed
the
fix/respond-via-message-npe
branch
from
July 13, 2026 07:25
44b303f to
6506425
Compare
RankoR
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 9aec6f6 replaced the argument-less notification refresh with BugleNotifications.updateWithInlineReply(conversationId, message), which is also reached from the recipients-only RESPOND_VIA_MESSAGE path where conversationId is null. Telecom invokes this exported service whenever the user rejects an incoming call with a quick-response text, and the null conversationId crashes on the non-null channelId parameter of NotificationChannelUtil.getActiveNotification. Since the service sets intent redelivery, the crash also redelivers the intent and re-sends the reply, causing duplicate texts alongside the crash loop.
Move the call into the branch where the conversation is known. The notification inline-reply path always supplies a conversation id, so its behavior is unchanged, and the recipients-only path has no active conversation notification to update in the first place.