Direct secondary users to the Owner user for MMS#204
Open
m4pl wants to merge 4 commits into
Open
Conversation
m4pl
changed the title
m4pl
marked this pull request as ready for review
July 14, 2026 14:27
RankoR
suggested changes
Jul 20, 2026
| state = MmsDownloadUiModel.State.AwaitingManualDownload, | ||
| sizeBytes = 2_048L, | ||
| expiryTimestamp = 1_700_000_000_000L, | ||
| isSecondaryUser = false, |
Contributor
There was a problem hiding this comment.
isSecondaryUser = true should be checked as well
Contributor
|
Looks like secondary user will still see "Tap to download" in the conversation list.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
Secondary users can't download MMS, so undownloaded messages now say "Download it from the Owner user" and the auto-retrieve switches are disabled with an explanation.
Seeder: dropped a fake
sms_message_uri. Because it was set, sync treated the seeded rows as real telephony messages and deleted them, so they disappeared on device.DownloadMmsAction/clearMmsStatus: added a null-URI guard so a local-only row without a telephony URI doesn't try to download. Real messages always have a URI, so nothing changes for them.