Fix failed-message notification being silently discarded#208
Open
thomasbuilds wants to merge 1 commit into
Open
Fix failed-message notification being silently discarded#208thomasbuilds wants to merge 1 commit into
thomasbuilds wants to merge 1 commit into
Conversation
checkFailedMessages still builds its notification with the channel-less NotificationCompat.Builder constructor - the one builder commit b6c8e0c missed when it moved every other notification to a channel. On API 26+ the system refuses to post notifications without a valid channel, so when an SMS/MMS send or MMS download fails, the "Message not sent" / "Message not downloaded" alert is silently dropped; outside a few transient toast cases, failures only surface through the error indicators inside the app.
thomasbuilds
force-pushed
the
fix/failed-message-notification-channel
branch
from
412f44e to
5e342a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkFailedMessages still builds its notification with the channel-less NotificationCompat.Builder constructor - the one builder commit b6c8e0c missed when it moved every other notification to a channel. On API 26+ the system refuses to post notifications without a valid channel, so when an SMS/MMS send or MMS download fails, the "Message not sent" / "Message not downloaded" alert is silently dropped; outside a few transient toast cases, failures only surface through the error indicators inside the app.