feat: add ChallengeCard component - #20
Merged
Merged
Conversation
satasatalight
requested review from
StevScripts,
alecocosette and
sebastian-noel
as code owners
June 17, 2026 18:26
sebastian-noel
force-pushed
the
feature/challenge-card
branch
from
July 23, 2026 02:35
8f4b952 to
92db15c
Compare
sebastian-noel
approved these changes
Jul 23, 2026
sebastian-noel
left a comment
Member
There was a problem hiding this comment.
looks good! fixed a few things to bring this in line with the rest of the site:
- Fixed heading misuse — the card used
<h1>/<h4>/<h3>purely for visual weight; switched to<p>to match TeamCard's pattern and avoid breaking the page's heading hierarchy - Added missing target="_blank" rel="noopener noreferrer" on the external challenge link
- Swapped text-gray-400 for the text-text-secondary design token
- Replaced the 📆 emoji with a FaRegCalendarAlt icon (react-icons, same as the hero section)
- Lightened the deadline date color (text-accent → text-accent-light) for better readability on the dark card background, and dropped the border on the month pill
- 2-space indentation, string[] over Array, minor formatting cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Creates the challenge card component displaying the latest GPK monthly challenge.
The element takes a "name" string with the challenge name, a "desc" string for the basic description, a "tags" array of strings for the challenge tags at the bottom of the card, a "deadline" JavaScript Date object to display the deadline of the challenge and the challenge month, and a "link" string for the challenge's corresponding link.
Type of Change
feat: New featurefix: Bug fixchore: Maintenance (dependencies, config, etc.)docs: Documentation onlystyle: Code style (formatting, no logic change)refactor: Code refactor (no new feature or fix)Changes Made
Screenshots (if applicable)
Checklist
npm run lintpasses without errorsnpm run buildcompletes successfullyRelated Issues
Closes Notion task "T10 (Challenges) - Build ChallengeCard component"