chore: added GitHub Actions CI/CD workflows - #5
Conversation
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions automation to standardize CI checks on PRs/pushes and to verify that the production Docker image still builds when relevant files change.
Changes:
- Added a CI workflow to run
npm run lintandnpm run buildon PRs and pushes tomain. - Added a Docker build workflow to validate the Docker image build on PRs/pushes when app/Docker-related paths change.
- Updated README to document the new CI/CD workflows and link to the Actions page.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
README.md |
Documents the new CI/CD workflows and updates contribution/infra notes. |
Dockerfile |
Minor comment update (removes hard-coded image size claim). |
.github/workflows/ci.yml |
New CI workflow running lint + build on PRs/pushes to main. |
.github/workflows/docker.yml |
New workflow that builds the Docker image on PRs/pushes with path filters + concurrency. |
Comments suppressed due to low confidence (1)
README.md:175
- The Markdown table has a formatting issue: the separator row’s third column includes an extra trailing space before the closing pipe (
|---------------------------- |), and the rows appear to rely on padded spacing. Cleaning up the table pipes/dashes will make it render consistently across Markdown viewers.
| Workflow | Trigger | What it does |
|-----------------|-----------------------------------------------|---------------------------- |
| **CI** | PRs and pushes to `main` | Runs lint and build |
| **Docker Build**| PRs/pushes affecting app code or Docker files | Verifies Docker image builds|
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - "Dockerfile" | ||
| - "docker-compose.yml" | ||
| - ".dockerignore" | ||
| - "package.json" | ||
| - "package-lock.json" | ||
| - "next.config.ts" | ||
| - "app/**" | ||
| - "components/**" | ||
| - "public/**" | ||
| - "styles/**" | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - "Dockerfile" | ||
| - "docker-compose.yml" | ||
| - ".dockerignore" | ||
| - "package.json" | ||
| - "package-lock.json" | ||
| - "next.config.ts" | ||
| - "app/**" | ||
| - "components/**" | ||
| - "public/**" | ||
| - "styles/**" |
There was a problem hiding this comment.
Because this workflow uses paths filters, changes to the workflow file itself won’t trigger a run on PRs/pushes. Add .github/workflows/docker.yml (and any other relevant workflow/config paths) to the paths list so updates to the workflow get validated before merge.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@sebastian-noel I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: sebastian-noel <179660949+sebastian-noel@users.noreply.github.com>
Add workflow self-path to docker.yml paths filter
alecocosette
left a comment
alecocosette
left a comment
There was a problem hiding this comment.
added docker and github actions for approval before a pr, looks good
Pull Request
Description
Add GitHub Actions CI/CD workflows to automate testing and verification. The CI workflow runs linting and builds on all PRs, while the Docker workflow ensures the production image builds successfully.
Type of Change
feat: New featurefix: Bug fixchore: Maintenance (dependencies, config, etc.)docs: Documentation onlystyle: Code style (formatting, no logic change)refactor: Code refactor (no new feature or fix)Changes Made
ci.yml- runs ESLint and build verification on all PRs and pushes to mainScreenshots (if applicable)
N/A
Checklist
npm run lintpasses without errorsnpm run buildcompletes successfullyRelated Issues
N/A