Say what a value asked for as a base type or an interface is

[danielcweber]

The contract both GraphSON deserializers are tested against now says what a value is when it is asked for as a base type or an interface - an IComparable, a ValueType, an EnumWrapper, the non-generic IEnumerable or IDictionary - where it said nothing before and the two implementations disagreed. A typed value is the type its name stands for to everything that can hold that type: a g:Int32 is an int to an IComparable, a g:T a T to an EnumWrapper. A bare scalar is what it is when asked for as an object. An array is an object[] and an object a Dictionary<string, object> to the non-generic collection interfaces.

Changes

• Tests.Infrastructure: 51 tests in GraphsonSupportTestBase, after DateTime_from_typed_Timestamp, and VerifyAttemptWithRuntimeType, which records the type of an answer next to its value - a snapshot of 5 does not say whether it is an int or a long.
  • A typed value as the type its name stands for: g:Int32, g:Float, g:Double, g:UUID, g:Date, g:Timestamp and the gx: numbers, gx:Duration and gx:Char asked for as an IComparable, IConvertible, IFormattable, ValueType or IEquatable<> of themselves; g:T, g:Direction and g:Merge as an EnumWrapper; g:Tree as an IEnumerable.
  • Where the requested type cannot hold that type, or the @value does not fit it, the bare @value is read instead - a g:UUID is a string to an IConvertible, a g:Int32 "abc" a string to an IComparable. Nothing throws.
  • A bare string, number and bool as a string, a long or double and a bool to whatever can hold one; a bare 5 is no IEquatable<int>. The items of an IComparable[] likewise.
  • An array, a g:List and a bulk set as an object[] to IEnumerable, ICollection and IList; an object and a map keyed by strings as a Dictionary<string, object> to IDictionary, ICollection and IEnumerable.
• Support.NewtonsoftJson.Tests: the 51 snapshots.

Notes

• Tests only. Every snapshot is what the Newtonsoft implementation answered before this change; nothing in src changes.
• Measured on the System.Text.Json implementation, which verifies against the same snapshots: 47 of the 51 differed there. Gremlinq/Gremlinq.Extensions#218 brings it to all 51 and has to be merged after this.
• Left unpinned on purpose, because Newtonsoft's answer there looks accidental: a bare true or "abc" as an IFormattable, a bare number or bool as an ICloneable or IEnumerable, and an object as an IList or ICloneable come back as the JValue or JObject itself; a map keyed by ints as an IDictionary comes back as an empty Dictionary<string, object>; an element map as an IDictionary comes back rebuilt as { id, label, properties }.
• Newtonsoft: 299 tests before, 350 after, all passing.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.70%. Comparing base (34c5793) to head (48327a6).

Additional details and impacted files

@@            Coverage Diff             @@
##             14.x    #2483      +/-   ##
==========================================
+ Coverage   93.68%   93.70%   +0.01%     
==========================================
  Files         279      279              
  Lines        7903     7905       +2     
  Branches      885      886       +1     
==========================================
+ Hits         7404     7407       +3     
  Misses        310      310              
+ Partials      189      188       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.