Repository navigation
Conversation
Backport GreptimeTeam#9093 as the shared protocol and storage test harness prerequisite for bulk request WAL skipping. Signed-off-by: WenyXu <wenymedia@gmail.com> (cherry picked from commit a673e08) Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>
Backport GreptimeTeam#9110 with its protocol update and Flight/Prometheus coverage. Keep the release branch's write dispatcher and partition-column retention, including the skip-WAL flag when retry routing rebuilds bulk requests. Signed-off-by: WenyXu <wenymedia@gmail.com> (cherry picked from commit 7370257) Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
|
Warning @v0y4g3r has 6 open non-draft pull requests in this repository, over the limit of 5. Review is the scarcest resource here. Please land or close some of these before
This check is advisory for now and blocks nothing. |
4 of 6 tasks
WenyXu
approved these changes
Oct 16, 2026
v0y4g3r
added a commit
to v0y4g3r/greptimedb
that referenced
this pull request
Oct 16, 2026
Merge release/5e02efa9 after GreptimeTeam#9627 and GreptimeTeam#9624. Resolve the worker test conflict using the shared memtable installation path, honor request-level bulk skip-WAL flags, and restore bulk close/reopen and WAL-only recovery coverage while preserving release-specific partition-column tests. Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
release/5e02efa9, in separate commits.What's changed and what's your intention?
Restore the missing skip-WAL prerequisites rather than maintaining a reduced close-flush backport around their absence.
The first commit copies #9093's integration harness and tests without functional changes. The second ports #9110: forwards the
insert_skip_walhint through Flight DoPut and bulk region RPCs, keeps different WAL policies in separate pending Prometheus batches, and skips bulk WAL entry construction while retaining memtable writes, sequence assignment, and completion notifications. Metric metadata writes remain WAL-backed. The proto dependency advances to the original #9110 revision0c4beffaa2b3968034915867593a717c6ab0c6b4(greptime-proto#339).Release-specific adaptations
The release branch already has the newer shared write dispatcher and partition-column preservation backports. Preserve them instead of restoring main's older direct-dispatch code:
skip_walon both initial bulk dispatch paths and through request rebuilding after partition-route changes.No persisted WAL/schema encoding changes. The additive protobuf flag defaults to false when omitted. Skip-WAL data remains vulnerable to loss before flush; this PR does not include the close-flush change from #9440.
Validation
client,frontend,operator,servers,store-api,mito2,metric-engine) plus skip-WAL/Flight integration selection: 2491 passed, 810 filtered/ignored tests not run.cargo sqlness bare -t '(session_skip_wal|copy_skip_wal)': 3 cases passed (session in standalone/distributed, COPY in standalone). Result files remain identical to the upstream-generated snapshots.--all-targets --no-deps -- -D warnings: passed..resultsnapshots retain their terminal blank lines.Full workspace tests, cross-version compatibility runs, and external-service Kafka runs were not executed. The distributed integration harness uses in-process services, not process-crash experiments.
PR Checklist
backport-<target>labels (e.g.backport-v1.3targetsrelease/v1.3).