Skip to content

Almost 26.1(.2) support. getCompleteVersion() method #108

Description

@mrfloris

LootChest is crashing before it really initializes because its version parser seems to try to turn Paper’s 26.1.2.build.52-beta style version into an integer, but accidentally leaves build in the string: 2612build52

[03:25:49 INFO]: [LootChest] Enabling LootChest v2.5.9
[03:25:49 ERROR]: Error occurred while enabling LootChest v2.5.9 (Is it up to date?)
java.lang.NumberFormatException: For input string: "2612build52"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) ~[?:?]
	at java.base/java.lang.Integer.parseInt(Integer.java:527) ~[?:?]
	at java.base/java.lang.Integer.parseInt(Integer.java:624) ~[?:?]
	at Lootchest-2.5.9.jar//fr.black_eyes.lootchest.Main.getCompleteVersion(Main.java:102) ~[?:?]
	at Lootchest-2.5.9.jar//fr.black_eyes.lootchest.Main.onEnable(Main.java:109) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[paper-api-26.1.2.build.52-beta.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:207) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-26.1.2.build.52-beta.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:637) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:594) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.MinecraftServer.initPostWorld(MinecraftServer.java:680) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:386) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1301) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at java.base/java.lang.Thread.run(Thread.java:1516) ~[?:?]
[03:25:49 INFO]: [LootChest] Disabling LootChest v2.5.9
[03:25:49 ERROR]: Error occurred while disabling LootChest v2.5.9
java.lang.NullPointerException: Cannot invoke "fr.black_eyes.lootchest.simpleJavaPlugin.SimpleJavaPlugin.getConfigFiles()" because "fr.black_eyes.lootchest.simpleJavaPlugin.Utils.plugin" is null
	at Lootchest-2.5.9.jar//fr.black_eyes.lootchest.simpleJavaPlugin.Utils.logInfo(Utils.java:95) ~[?:?]
	at Lootchest-2.5.9.jar//fr.black_eyes.lootchest.simpleJavaPlugin.SimpleJavaPlugin.onDisable(SimpleJavaPlugin.java:32) ~[?:?]
	at Lootchest-2.5.9.jar//fr.black_eyes.lootchest.Main.onDisable(Main.java:49) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:285) ~[paper-api-26.1.2.build.52-beta.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:242) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugin(PaperPluginManagerImpl.java:114) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:550) ~[paper-api-26.1.2.build.52-beta.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:211) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-26.1.2.build.52-beta.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:637) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:594) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.MinecraftServer.initPostWorld(MinecraftServer.java:680) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:386) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1301) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[paper-26.1.2.jar:26.1.2-52-174eab0]
	at java.base/java.lang.Thread.run(Thread.java:1516) ~[?:?]

2 spots: the numeric version parser that crashes on build.52, and the fall-effect class lookup so .2 still loads under 26.1 class

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions