Feature/RGB shiftlights & dynamic rev limiter#87
Conversation
412ade3 to
7e628ee
Compare
|
Hi Max RPM does not represent the redline. Max RPM only indicates the vehicle’s maximum RPM value. I was also considering adding the RGB Shift Lights feature. Glad you added it; I’ll take a look when I have some free time. Thanks for PR |
Hi, Thanks for the reply! I'm aware of the distinction between max RPM and the actual redline. In the current implementation, I temporarily overwrite the max RPM value with the detected redline RPM purely to simplify the downstream trigger and LED calculations — this makes it much easier to pinpoint the exact shift point. That said, you're absolutely right that there's no specific optimization for EVs yet. Single- or two-speed EVs could indeed cause persistent vibration at high speeds under this logic. Really appreciate the heads-up |
PR Description
Hi there! 👋
This PR introduces two new features aimed at enhancing the adaptive feedback experience:
✨ Dynamic Redline Detection
rpm / max_rpmratio. Since redline RPM values vary widely across vehicles, this often leads to inaccurate trigger points and requires manual per-car tuning.max_rpm, then reads real-time telemetry data (throttle position and RPM changes) to dynamically calculate the precise redline zone. A vehicle ID check is used to detect car swaps and automatically recalibrate.🌈 RGB Shift Lights
⚙️ GUI Integration
A quick note: I'm not a professional developer, and I used AI assistance to help write parts of the code. As a result, some implementation details may differ slightly from the latest codebase conventions. I've done my best to keep things clean and functional, but I truly appreciate any feedback or suggestions for improvement!
Thanks for reviewing — hope you find these additions useful! 🙌