Fix [Sail] OnLoadGame hook does not trigger#6729
Open
JD-Spencer wants to merge 1 commit into
Open
Conversation
…hook is triggered. When the OnLoadGame hook is triggered, IsSaveLoaded() returns false, causing the hook to not process.
serprex
reviewed
Jun 12, 2026
|
|
||
| COND_HOOK(OnLoadGame, isConnected, [&](int32_t fileNum) { | ||
| if (!isConnected || !GameInteractor::IsSaveLoaded()) | ||
| if (!isConnected) |
Member
There was a problem hiding this comment.
even isConnected should never be false since it's the condition of the hook
wondering if this is supposed to be blocking things like debug save file etc
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
OnLoadGamehook is triggered,GameInteractor::IsSaveLoaded()returns false, causing the hook to not process.Removed the check and now it works as expected.
Build Artifacts