Skip to content

fix(git): force core.longpaths=true on Windows for native git commands #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Spelt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(git): force core.longpaths=true on Windows for native git commands #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions internal/adapters/secondary/git/git_native.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"os"
"os/exec"
"path/filepath"
"runtime"

git2 "github.com/go-git/go-git/v5"
"github.com/go-git/go-git/v5/plumbing"
Expand All @@ -17,6 +18,17 @@ import (
"github.com/hashload/boss/pkg/msg"
)

// gitCommand builds a system git command. On Windows it forces core.longpaths=true
// so checkouts of repositories with paths beyond MAX_PATH (260 chars) don't fail
// with "Filename too long" when the user's git config lacks that setting.
func gitCommand(args ...string) *exec.Cmd {
if runtime.GOOS == "windows" {
args = append([]string{"-c", "core.longpaths=true"}, args...)
}
//nolint:gosec,nolintlint // Git command with controlled arguments
return exec.CommandContext(context.Background(), "git", args...) // #nosec G204 -- Controlled git command
}

func checkHasGitClient() {
command := exec.CommandContext(context.Background(), "where", "git")
_, err := command.Output()
Expand Down Expand Up @@ -66,8 +78,7 @@ func doClone(dep domain.Dependency) error {

args = append(args, dep.GetURL(), dirModule)

//nolint:gosec,nolintlint // Git command with controlled and validated repository URL
cmd := exec.CommandContext(context.Background(), "git", args...) // #nosec G204 -- Controlled git clone command
cmd := gitCommand(args...)

if err = runCommand(cmd); err != nil {
return err
Expand Down Expand Up @@ -99,13 +110,13 @@ func getWrapperFetch(dep domain.Dependency) error {
}

writeDotGitFile(dep)
cmdReset := exec.CommandContext(context.Background(), "git", "reset", "--hard")
cmdReset := gitCommand("reset", "--hard")
cmdReset.Dir = dirModule
if err := runCommand(cmdReset); err != nil {
return err
}

cmd := exec.CommandContext(context.Background(), "git", "fetch", "--all")
cmd := gitCommand("fetch", "--all")
cmd.Dir = dirModule

if err := runCommand(cmd); err != nil {
Expand All @@ -122,7 +133,7 @@ func getWrapperFetch(dep domain.Dependency) error {

func initSubmodulesNative(dep domain.Dependency) error {
dirModule := filepath.Join(env.GetModulesDir(), dep.Name())
cmd := exec.CommandContext(context.Background(), "git", "submodule", "update", "--init", "--recursive")
cmd := gitCommand("submodule", "update", "--init", "--recursive")
cmd.Dir = dirModule

if err := runCommand(cmd); err != nil {
Expand All @@ -134,16 +145,15 @@ func initSubmodulesNative(dep domain.Dependency) error {
// CheckoutNative switches the dependency repository to the given reference using system git.
func CheckoutNative(dep domain.Dependency, referenceName plumbing.ReferenceName) error {
dirModule := filepath.Join(env.GetModulesDir(), dep.Name())
cmd := exec.CommandContext(context.Background(),
"git", "checkout", "-f", referenceName.Short()) // #nosec G204 -- Controlled git checkout command
cmd := gitCommand("checkout", "-f", referenceName.Short())
cmd.Dir = dirModule
return runCommand(cmd)
}

// PullNative fetches and merges updates using system git.
func PullNative(dep domain.Dependency) error {
dirModule := filepath.Join(env.GetModulesDir(), dep.Name())
cmd := exec.CommandContext(context.Background(), "git", "pull", "--force")
cmd := gitCommand("pull", "--force")
cmd.Dir = dirModule
return runCommand(cmd)
}
Expand Down