feat(subagent): add getArgumentCompletions for agent names#58
Open
monkeyxite wants to merge 1 commit into
Open
feat(subagent): add getArgumentCompletions for agent names#58monkeyxite wants to merge 1 commit into
monkeyxite wants to merge 1 commit into
Conversation
The /subagent slash command previously had no argument autocompletion. Pi's SDK supports getArgumentCompletions on registerCommand (docs/extensions.md); this wires it to discoverAgentDefinitions() so agent names complete on Tab. Only completes the agent-name arg — task argument stays freeform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pi's SDK supports
getArgumentCompletionsonpi.registerCommand(seedocs/extensions.md), but the/subagentslash command didn't implement it — so typing/subagentand pressing Tab showed no suggestions even though this extension is precisely the one that knows what agents are available.Change
Wire
getArgumentCompletionsto the existingdiscoverAgentDefinitions()(already used elsewhere in the file). One import added (AutocompleteItemfrom@mariozechner/pi-tui), one callback added to the/subagentcommand options at index.ts:1981.Behaviour:
name.{ value, label }items wherelabelcombines name + description.null(per SDK contract) when the filtered list is empty.nullwhen the prefix contains a space — the user is in the freeform task-arg territory, no completion appropriate.Scope discipline: only
pi-extension/subagents/index.tsis touched./planand/iterateare untouched.Verification
getArgumentCompletionsinside the/subagentblock (plus the import).ERR_MODULE_NOT_FOUNDonnpm testis pre-existing onmain, unrelated to this change).Not changed
/planand/iterate— same completion gap exists there but is out of scope.