Move Job_* script constants and @jobchange help text to source - #3422
Open
MrKeiKun wants to merge 4 commits into
Open
Move Job_* script constants and @jobchange help text to source#3422MrKeiKun wants to merge 4 commits into
MrKeiKun wants to merge 4 commits into
Conversation
…onf, closing the remaining item from HerculesWS#165.
…text in conf/map/help.txt.
…py's skip list, matching the existing atcommand_help_string precedent.
…(comparing a string literal against NULL) under /WX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Job_*script constants (previously duplicated by hand indb/constants.conf) from theJOB_ENUM_VALUEX-macro already used inclass.h/class_hidden.h/class_special.h, so they can never drift from theJOB_*enum.@jobchange/@help jobchangejob listing at boot from that same source data pluspc->job_name(), instead of a hand-maintained, hand-aligned block inconf/map/help.txt.Issues addressed: #165