Conversation
Wall of Thorn's Unit.Interval was -1, so the Fire Wall it morphs into on fire damage never ticked. Also add the missing 20-hit break limit on the base unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Wall of Thorn (GN_WALLOFTHORN) is supposed to burn into a Fire Wall (UNT_FIREWALL) when hit by fire damage, but the resulting fire never actually dealt damage:
GN_WALLOFTHORN'sUnit.Intervalwas-1in bothdb/re/skill_db.confanddb/pre-re/skill_db.conf. Wall of Thorn itself has no periodic on-place tick, so this was fine for its own state, but the morphed Fire Wall unit inherits this same interval. Withinterval == -1,skill_unit_onplace_timerhits its early-exit guard and logs"interval error"instead of ticking, so the fire never dealt damage for its whole 3-second lifetime. Changed to300.val2held an unused caster ID instead of a hit counter. It now starts at 20 and is decremented on each weapon hit inbattle.c(mirroring the existingHT_BLASTMINEhook in the same block), deleting the unit once depleted.skill_unit_timer_sub's expiry check was updated to also break the wall whenval2reaches 0, not just on HP depletion.Issues addressed: #1118