Validate before allocating WFIFO buffer, not after - #3435
Open
MrKeiKun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Several functions called
WFIFOHEADbefore finishing validation/data-gathering, thenreturned without callingWFIFOSET. Reordered so checks happen first and the buffer is only allocated once a packet is actually going to be sent:chrif_save_scdata: count active status changes before allocating.chrif_update_ip: check whether the IP changed before allocating.clif_updatestatus: reject an unrecognizedtypebefore allocating (added a validation switch mirroring the real switch's case labels, since the valid values aren't a contiguous range).clif_use_card: count insertable items before allocating.clif_sendegg: count hatchable pet eggs before allocating.Issues addressed: #1041