Fix/renewal matk batk issue 2653 - #3437
Open
MrKeiKun wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
batk,matk_min,matk_maxinstatus_datafromuint32toint, allowing negative values as in official AEGIS.buff_extra_matk(mirroring the existingbuff_extra_batk) so MATK bonuses from status changes likeSC_IMPOSITIOandSC_VOLCANOare tracked separately and shown on the right side of the status window, instead of being silently folded into the base MATK value.status_calc_batk/status_calc_matkso fixed (flat) bonuses are applied before percent-based bonuses, so percent modifiers consistently multiply against the full base+flat total instead of an partially-modified intermediate value.Issues addressed: #2653