Fix uninitialized WFIFO/RFIFO buffer memory on realloc - #3439
Open
MrKeiKun wants to merge 1 commit into
Open
Conversation
Fixes uninitialized heap memory being sent to clients when packet buffers grow, as realloc() does not clear newly extended memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
realloc_fifo(): zero the newly added tail ofrdata/wdataafter eachRECREATE, when the new size is larger than the old one.realloc_writefifo(): same, but only on the grow path (the shrink path frees no new memory, so nothing to zero there).size_tunderflow in thememsetlength.Issues addressed: #1743