Generate @command usage messages from the invoked command name - #3441
Open
MrKeiKun wants to merge 1 commit into
Open
Generate @command usage messages from the invoked command name#3441MrKeiKun wants to merge 1 commit into
MrKeiKun wants to merge 1 commit into
Conversation
Usage messages hardcoded command aliases, which drifted from atcommand.conf and named commands that no longer exist. Replace them with a %s filled from the command the player actually typed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Command usage messages hardcoded their command names and alias lists, so they
drifted out of sync with
conf/atcommand.confand could not reflect a server'sactual configuration.
This replaces the hardcoded names with a
%sfilled from the command the playeractually typed, as suggested by @MishimaHaruna in the issue:
Before:
After:
This also fixes messages that named the wrong command entirely:
@blvl,@jlvland
@glvllisted only aliases and never their own name;@shownpcreportedusage: @enablenpc, which does not exist; and@nuke,@partyspyand@guildspyreported the usage of the command they shared a message with.Note that translations will need the same
%schange. The surrounding text isuntouched, so only the usage portion is affected.
Issues addressed: #228