Skip to content

Exclude Desperado from ShortWeaponDamageReturn reflect - #3444

Open
MrKeiKun wants to merge 1 commit into
HerculesWS:masterfrom
MrKeiKun:fix/issue-808-desperado-reflect
Open

Exclude Desperado from ShortWeaponDamageReturn reflect#3444
MrKeiKun wants to merge 1 commit into
HerculesWS:masterfrom
MrKeiKun:fix/issue-808-desperado-reflect

Conversation

@MrKeiKun

@MrKeiKun MrKeiKun commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Pull Request Prelude

Changes Proposed

Desperado (GS_DESPERADO) is a short-range attack, so it currently triggers reflect damage from equipment/cards with bShortWeaponDamageReturn (e.g. Horn Card). On official (Aegis) servers it does not.

Hercules already excludes Desperado from Shield Reflect (SC_REFLECTSHIELD) for the same reason, added specifically for this behavior:

if( sc->data[SC_REFLECTSHIELD] && skill_id != WS_CARTTERMINATION && skill_id != GS_DESPERADO

but the equivalent bonus.short_weapon_damage_return check a few lines above never received the same exception. This PR adds it, mirroring the existing pattern:

if ( tsd && tsd->bonus.short_weapon_damage_return && skill_id != GS_DESPERADO ) {

Flip Tatami (NJ_TATAMIGAESHI) remains unaffected and continues to be reflected correctly, matching official behavior as described in the issue.

Issues addressed: #808

@MrKeiKun
MrKeiKun force-pushed the fix/issue-808-desperado-reflect branch from a46796b to ebd2be1 Compare September 1, 2026 11:23
@MrKeiKun
MrKeiKun force-pushed the fix/issue-808-desperado-reflect branch from ebd2be1 to df4c8e0 Compare September 1, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant