Implement code changes required to compile Hercules as C++

.clang-format

@@ -0,0 +1,120 @@
+---
+BasedOnStyle: LLVM
+Language:        Cpp
+AccessModifierOffset: -6
+AlignAfterOpenBracket: Align
+AlignArrayOfStructures: Right
+AlignConsecutiveAssignments:
+  Enabled:         true
+  AcrossEmptyLines: false
+  AcrossComments:  true
+  AlignCompound:   true
+  PadOperators:    true
+AlignConsecutiveBitFields:
+  Enabled:         true
+  AcrossEmptyLines: false
+  AcrossComments:  true
+  AlignCompound:   false
+  PadOperators:    false
+AlignConsecutiveDeclarations:
+  Enabled:         false
+  AcrossEmptyLines: false
+  AcrossComments:  false
+  AlignCompound:   false
+  PadOperators:    false
+AlignConsecutiveMacros:
+  Enabled:         true
+  AcrossEmptyLines: false
+  AcrossComments:  true
+  AlignCompound:   false
+  PadOperators:    false
+AlignEscapedNewlines: Left
+AlignOperands:   AlignAfterOperator
+AlignTrailingComments: true
+AllowAllArgumentsOnNextLine: true
+AllowShortEnumsOnASingleLine: false
+AllowShortBlocksOnASingleLine: Never
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: None
+AllowShortLambdasOnASingleLine: Inline
+AllowShortIfStatementsOnASingleLine: Never
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakAfterReturnType: None
+AlwaysBreakBeforeMultilineStrings: true
+AlwaysBreakTemplateDeclarations: Yes
+BinPackArguments: false
+BinPackParameters: true
+BreakBeforeBinaryOperators: All
+BreakBeforeConceptDeclarations: Allowed
+BreakBeforeBraces: Linux
+BreakBeforeTernaryOperators: true
+BreakConstructorInitializers: BeforeColon
+BreakStringLiterals: true
+ColumnLimit:     120
+QualifierAlignment: Left
+CompactNamespaces: true
+ConstructorInitializerIndentWidth: 8
+ContinuationIndentWidth: 8
+Cpp11BracedListStyle: true
+DeriveLineEnding: false
+DerivePointerAlignment: false
+DisableFormat:   false
+EmptyLineAfterAccessModifier: Leave
+EmptyLineBeforeAccessModifier: LogicalBlock
+PackConstructorInitializers: NextLine
+FixNamespaceComments: true
+IncludeBlocks:   Preserve
+IndentAccessModifiers: false
+IndentCaseLabels: false
+IndentCaseBlocks: false
+IndentGotoLabels: false
+IndentPPDirectives: AfterHash
+IndentExternBlock: NoIndent
+IndentRequiresClause: true
+IndentWidth:     8
+IndentWrappedFunctionNames: true
+InsertBraces:    false
+InsertTrailingCommas: None
+KeepEmptyLinesAtTheStartOfBlocks: false
+LambdaBodyIndentation: OuterScope
+MaxEmptyLinesToKeep: 1
+NamespaceIndentation: None
+PointerAlignment: Right
+PPIndentWidth:   2
+ReferenceAlignment: Right
+ReflowComments:  true
+RequiresClausePosition: OwnLine
+SeparateDefinitionBlocks: Always
+ShortNamespaceLines: 0
+SortIncludes:    CaseInsensitive
+SortUsingDeclarations: true
+SpaceAfterCStyleCast: false
+SpaceAfterLogicalNot: false
+SpaceAfterTemplateKeyword: false
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeCaseColon: false
+SpaceBeforeCpp11BracedList: false
+SpaceBeforeCtorInitializerColon: true
+SpaceBeforeInheritanceColon: true
+SpaceBeforeParens: ControlStatements
+SpaceAroundPointerQualifiers: Default
+SpaceBeforeRangeBasedForLoopColon: true
+SpaceInEmptyBlock: false
+SpaceInEmptyParentheses: false
+SpacesBeforeTrailingComments: 1
+SpacesInAngles:  Never
+SpacesInConditionalStatement: false
+SpacesInContainerLiterals: true
+SpacesInCStyleCastParentheses: false
+SpacesInLineCommentPrefix:
+  Minimum:         1
+  Maximum:         -1
+SpacesInParentheses: false
+SpacesInSquareBrackets: false
+SpaceBeforeSquareBrackets: false
+BitFieldColonSpacing: Both
+Standard:        c++20
+TabWidth:        8
+UseCRLF:         false
+UseTab:          ForIndentation
+...

.gitattributes

@@ -1,5 +1,6 @@
 *     text=auto
 *.c   diff=cpp
+*.cpp diff=cpp
 *.sh  text eol=lf
 *.bat text eol=crlf
 

3rdparty/mt19937ar/mt19937ar.h

@@ -43,6 +43,10 @@
    email: m-mat @ math.sci.hiroshima-u.ac.jp (remove space)
 */
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /* initializes mt[N] with a seed */
 void init_genrand(unsigned long s);
 
@@ -70,3 +74,7 @@ double genrand_real3(void);
 
 /* generates a random number on [0,1) with 53-bit resolution*/
 double genrand_res53(void);
+
+#ifdef __cplusplus
+}
+#endif

CMakeLists.txt

@@ -24,6 +24,9 @@ project(hercules LANGUAGES C CXX)
 set(CMAKE_C_STANDARD 11)
 set(CMAKE_C_STANDARD_REQUIRED ON)
 set(CMAKE_C_EXTENSIONS ON)
+set(CMAKE_CXX_STANDARD 20)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
+set(CMAKE_CXX_EXTENSIONS NO)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON CACHE BOOL "Enable compile commands" FORCE)
 if(NOT CMAKE_SYSTEM_NAME STREQUAL "Windows")
   set(CMAKE_INSTALL_LIBDIR "lib")
@@ -164,7 +167,7 @@ if(MSVC)
   add_compile_options(/wd4100) # Disable unused parameter warning mostly due to BUILDIN and similar functions having unused parameters
   add_compile_options(/wd4312) # Disable conversion to greater size warning (see 0xdeadbeef pointers)
   # Definations
-  add_compile_definitions(WIN32 _WIN32 __WIN32 _CRT_SECURE_NO_DEPRECATE _CRT_NONSTDC_NO_DEPRECATE FD_SETSIZE=4096 WIN32_LEAN_AND_MEAN)
+  add_compile_definitions(WIN32 _WIN32 __WIN32 _CRT_SECURE_NO_DEPRECATE _CRT_NONSTDC_NO_DEPRECATE FD_SETSIZE=4096 WIN32_LEAN_AND_MEAN NOMINMAX)
 else()
   # Check for mandatory compile flags
   include(CompilerFlagHelpers)

cmake_modules/CompilerFlagHelpers.cmake

@@ -42,6 +42,26 @@ function(testadd_warning_compiler_flag _name)
   endif()
 endfunction()
 
+function(testadd_warning_compiler_flag_target _target_name _name)
+  set(options REQUIRED)
+  cmake_parse_arguments(PARSE_ARGV
+    1
+    arg
+    "${options}"
+    ""
+    ""
+  )
+
+  string(REGEX REPLACE "[^A-Za-z0-9_]" "_" _TESTADD_WARNING_FLAG_NAME _TESTADD_WARNING_FLAG_${_name})
+  set(CMAKE_REQUIRED_FLAGS "-Werror -Wfatal-errors")
+  check_c_compiler_flag("-W${_name}" ${_TESTADD_WARNING_FLAG_NAME}_FOUND)
+  if(${_TESTADD_WARNING_FLAG_NAME}_FOUND)
+    target_compile_options(${_target_name} PRIVATE "-W${_name}")
+  elseif(${arg_REQUIRED})
+    message(FATAL_ERROR "Compiler warning flag -W${_name} is required")
+  endif()
+endfunction()
+
 # Tests for compiler flag
 # _name flag name
 # REQUIRED flag to fail if check doesn't pass

conf/map/battle/battle.conf

@@ -81,6 +81,7 @@ undead_detect_type: 0
 attribute_recover: false
 
 // What is the minimum and maximum hit rate of normal attacks?
+// min must not be greater than max.
 min_hitrate: 5
 max_hitrate: 100
 

conf/map/battle/client.conf

@@ -43,6 +43,7 @@ packet_obfuscation: 2
 min_chat_delay: 0
 
 // Valid range of dyes and styles on the client.
+// min must not be greater than max.
 min_hair_style: 0
 max_hair_style: 29
 min_hair_color: 0

conf/map/battle/drops.conf

@@ -61,51 +61,60 @@ mvp_item_third_get_time: 2000
 // Item drop rates (Note 2)
 
 // The rate the common items are dropped (Items that are in the ETC tab, besides card).
+// min must not be greater than max.
 item_rate_common: 100
 item_rate_common_boss: 100
 item_drop_common_min: 1
 item_drop_common_max: 10000
 
 // The rate healing items are dropped (items that restore HP or SP).
+// min must not be greater than max.
 item_rate_heal: 100
 item_rate_heal_boss: 100
 item_drop_heal_min: 1
 item_drop_heal_max: 10000
 
 // The rate at which usable items (in the item tab) other then healing items are dropped.
+// min must not be greater than max.
 item_rate_use: 100
 item_rate_use_boss: 100
 item_drop_use_min: 1
 item_drop_use_max: 10000
 
 // The rate at which equipment is dropped.
+// min must not be greater than max.
 item_rate_equip: 100
 item_rate_equip_boss: 100
 item_drop_equip_min: 1
 item_drop_equip_max: 10000
 
 // The rate at which cards are dropped.
+// min must not be greater than max.
 item_rate_card: 100
 item_rate_card_boss: 100
 item_drop_card_min: 1
 item_drop_card_max: 10000
 
 // The rate adjustment for the MVP items that the MVP gets directly in their inventory.
+// min must not be greater than max.
 item_rate_mvp: 100
 item_drop_mvp_min: 1
 item_drop_mvp_max: 10000
 
 // The rate adjustment script-granted single drop bonuses
+// min must not be greater than max.
 item_rate_adddrop: 100
 item_drop_add_min: 1
 item_drop_add_max: 10000
 
 // The rate adjustment for items declared in item_chain.conf
+// min must not be greater than max.
 item_rate_add_chain: 100
 item_drop_add_chain_min: 1
 item_drop_add_chain_max: 10000
 
 // Rate adjustment for Treasure Box drops (these override all other modifiers)
+// min must not be greater than max.
 item_rate_treasure: 100
 item_drop_treasure_min: 1
 item_drop_treasure_max: 10000

conf/map/battle/limits.conf

@@ -28,29 +28,36 @@
 //=========================================================================
 
 // basic attack limits
+// min must not be greater than max.
 batk_min_limit: 0
 batk_max_limit: 65535
 
 // magic attack limits
+// min must not be greater than max.
 matk_min_limit: 0
 matk_max_limit: 65535
 
 // weapon attack limits
+// min must not be greater than max.
 watk_min_limit: 0
 watk_max_limit: 65535
 
 // flee limits
+// min must not be greater than max.
 flee_min_limit: 1
 flee_max_limit: 32767
 
 // flee2 limits
+// min must not be greater than max.
 flee2_min_limit: 10
 flee2_max_limit: 32767
 
 // critical attack limits
+// min must not be greater than max.
 critical_min_limit: 10
 critical_max_limit: 32767
 
 // hit limits
+// min must not be greater than max.
 hit_min_limit: 1
 hit_max_limit: 32767

conf/map/script.conf

@@ -51,12 +51,14 @@ script_configuration: {
 
 	// Default value of the 'min' argument of the script command 'input'.
 	// When the 'min' argument isn't provided, this value is used instead.
+	// 'min' must not be greater than 'max'.
 	// Defaults to 0
 	input_min_value: 0
 
 	// Default value of the 'max' argument of the script command 'input'.
 	// When the 'max' argument isn't provided, this value is used instead.
 	// Max allowed value that can be used is INT_MAX (2147483647).
+	// 'min' must not be greater than 'max'.
 	// Defaults to 10000000
 	input_max_value: 10000000
 

conf/messages.conf

@@ -1507,7 +1507,7 @@
 1391: You do not possess a cart to be removed
 1392: Cart Added.
 
-// atcommand.c::is_atcommand
+// atcommand.cpp::is_atcommand
 1393: You can't use commands while dead.
 
 // @clearstorage
@@ -1607,19 +1607,19 @@
 1472: - Available Costumes
 1473: Costume '%s' removed.
 
-//src/map/pc.c::pc_isUseitem
+//src/map/pc.cpp::pc_isUseitem
 1474: You cannot use this item while sitting.
 1475: You cannot use this item while your storage is open.
 
 1476: You are already mounting something else.
 
-//src/map/pc.c::pc_isUseitem
+//src/map/pc.cpp::pc_isUseitem
 1477: Item cannot be opened when inventory is full.
 
 //@homlv
 1478: Homunculus reached its maximum level of '%d'.
 
-//src/map/clif.c::clif_parse_GlobalMessage
+//src/map/clif.cpp::clif_parse_GlobalMessage
 1479: Dear angel, can you hear my voice?
 1480: I am %s Super Novice~
 1481: Help me out~ Please~ T_T
@@ -1628,10 +1628,10 @@
 1482: You can't withdraw that much money.
 1483: Banking is disabled.
 
-//src/map/atcommand.c::ACMD(auction)
+//src/map/atcommand.cpp::ACMD(auction)
 1484: Auction is disabled.
 
-// src/map/clif.c::clif_change_title_ack
+// src/map/clif.cpp::clif_change_title_ack
 1485: Title is not yet earned.
 
 // Monster Transformation

conf/plugins.conf

@@ -27,7 +27,7 @@ plugins_list: [
 ]
 -----------------------------------------
 Please note that your scripts need to be saved
-in the .c (source code) extension and placed in the /src/plugin/ folder.
+in the .cpp (source code) extension and placed in the /src/plugin/ folder.
 -----------------------------------------
 */
 plugins_list: [

db/cashshop_db.conf

@@ -31,7 +31,7 @@
 // Cashshop does not work with ragexeRE clients.
 // Categories can be empty or even missing, but, if present, their names
 // must be kept as cat_<n>, where <n> is a valid tab index, as described
-// in 'enum CASH_SHOP_TABS' in clif.c (normally 0 through 7)
+// in 'enum CASH_SHOP_TABS' in clif.cpp (normally 0 through 7)
 //=========================================================================
 
 cash_shop: (

db/constants.conf

@@ -471,7 +471,7 @@ constants_db: {
 	bDropAddRace:             2067
 
 	comment__: "Equip index"
-	/* reference to script.c::script_defaults():equip[] array used for easy-conversion */
+	/* reference to script.cpp::script_defaults():equip[] array used for easy-conversion */
 	EQI_HEAD_TOP:          1
 	EQI_ARMOR:             2
 	EQI_HAND_L:            3