Conversation
Hermesiss
force-pushed
the
develop
branch
2 times, most recently
from
July 6, 2025 07:44
a94e60e to
0bc7092
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a beta update channel (“latest-dev”) throughout the app:
- Defines a new
setUpdateChannelIPC method and exposes it in preload. - Renders a UI switch to toggle between stable and beta channels and invokes the new API.
- Implements channel switching in
UpdateService, initializes on startup, and adjusts CI/CD workflows to publish bothlatestandlatest-devreleases (including blockmap assets).
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/types/common.ts | Added setUpdateChannel to the ElectronAPI types |
| src/renderer/components/UpdateButton.vue | UI switch + logic to persist/use beta update channel |
| src/main/updateService.ts | IPC handler + setUpdateChannel logic |
| src/main/preload.ts | Exposed setUpdateChannel in contextBridge |
| src/main/tests/updateService.test.ts | Updated test assertions for feed URL & mocks |
| package.json | Bumped version to 1.2.5 |
| .github/workflows/build-and-release.yml | CI edits for beta releases and blockmap uploads |
Comments suppressed due to low confidence (7)
src/renderer/types/common.ts:60
- Consider adding a JSDoc comment for
setUpdateChannelto explain its purpose and valid channel values to future maintainers.
setUpdateChannel: (channel: 'latest' | 'latest-dev') => Promise<void>;
src/renderer/components/UpdateButton.vue:76
- This new toggle logic and
handleBetaChannelChangebehavior should be covered by a unit test (e.g., mockinglocalStorageandelectronAPI.setUpdateChannel).
const useBetaChannel = ref(localStorage.getItem('useBetaChannel') === 'true');
src/main/tests/updateService.test.ts:12
- Add a test to verify that
ipcMain.handle('set-update-channel', ...)is registered and that calling it invokessetUpdateChannelwith the correct channel.
}
.github/workflows/build-and-release.yml:273
- The workflow uses
distfor Linux artifacts butartifacts/macosfor macOS; unify the directory paths or confirm both locations exist to avoid missing files.
id: find-installer
.github/workflows/build-and-release.yml:405
- This upload references
artifacts/linux/...but earlier steps place blockmaps indist/; the paths should be consistent to ensure successful uploads.
APPIMAGE=$(find artifacts/linux -name "*.AppImage" -type f | head -1)
.github/workflows/build-and-release.yml:386
- [nitpick] There is a lot of repetitive
upload_assetlogic. Consider iterating over an asset list or using a reusable workflow to reduce duplication.
upload_asset() {
src/main/updateService.ts:43
- Previously the code configured
updateConfigPathper platform; removing that may break platform-specific updates. EnsureupdateConfigPathis still set or validate platform behavior.
this.setUpdateChannel("latest");
Hermesiss
force-pushed
the
develop
branch
4 times, most recently
from
July 6, 2025 08:28
b1f140f to
30cf78f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add beta channel to auto update