Skip to content

fix(mcp): only advertise list-resource meta-tools when resources exist #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h3c-hexin wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(mcp): only advertise list-resource meta-tools when resources exist #3963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/tui/src/mcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,7 +1915,13 @@ impl McpPool {
});
}

if !self.config.servers.is_empty() {
// Only advertise each resource-listing meta-tool when the servers actually
// expose the corresponding kind. Previously both were injected whenever any
// MCP server was configured, so tools-only servers left the model with
// meta-tools that can only ever return empty results — a wasted tool slot
// and prompt tokens. Gate each on its own non-empty collection, mirroring
// the `mcp_read_resource` guard below (`!resources.is_empty()`).
if !self.all_resources().is_empty() {
api_tools.push(crate::models::Tool {
tool_type: None,
name: "list_mcp_resources".to_string(),
Expand All @@ -1932,6 +1938,8 @@ impl McpPool {
strict: None,
cache_control: None,
});
}
if !self.all_resource_templates().is_empty() {
api_tools.push(crate::models::Tool {
tool_type: None,
name: "list_mcp_resource_templates".to_string(),
Expand Down
Loading