perf(tui): avoid redundant composer input wrapping per frame#3967
Open
reidliu41 wants to merge 1 commit into
Open
perf(tui): avoid redundant composer input wrapping per frame#3967reidliu41 wants to merge 1 commit into
reidliu41 wants to merge 1 commit into
Conversation
Owner
|
Thanks @reidliu41. This is a good, focused perf slice and I would like to take it, but I want one small correctness/test follow-up first: please pin the empty-input behavior for The PR is clean and green, and it merged into the local scratch train with the other 0.8.67 PRs. If you can add that small guard quickly, this can still fit before I cut 0.8.67; otherwise I will route it to 0.8.68 rather than lose the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix performance issue where composer input text was being wrapped up to five times per render frame. The redundant wrapping occurred because
layout_input_with_scrolland the selection rendering code each called their own wrap functions.Fixes
Fixes #3909
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist