Skip to content

test: Add lock to fix env conflict in test#4031

Merged
Hmbown merged 1 commit into
Hmbown:mainfrom
hongqitai:test/env-conflict
Jul 5, 2026
Merged

test: Add lock to fix env conflict in test#4031
Hmbown merged 1 commit into
Hmbown:mainfrom
hongqitai:test/env-conflict

Conversation

@hongqitai

Copy link
Copy Markdown
Contributor

Summary

The test direct_provider_ignores_foreign_deepseek_root_default_model will read env DEEPSEEK_BASE_URL.
But deepseek_base_url_env_scopes_to_self_hosted_providers will write it and cause test failed.
Use lock_test_env get lock before test in direct_provider_ignores_foreign_deepseek_root_default_model.

Testing

  • [ x ] cargo fmt --all -- --check
  • [ x ] cargo clippy --workspace --all-targets --all-features
  • [ x ] cargo test --workspace --all-features

Checklist

  • [ x ] Updated docs or comments as needed
  • [ x ] Added or updated tests where relevant
  • [ x ] Verified TUI behavior manually if UI changes
  • [ x ] Harvested/co-authored credit uses a GitHub numeric noreply address

@hongqitai hongqitai requested a review from Hmbown as a code owner July 4, 2026 13:28

@Hmbown Hmbown left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct fix: direct_provider_ignores_foreign_deepseek_root_default_model reads DEEPSEEK_BASE_URL while a sibling test writes it; taking lock_test_env() serializes them. Matches the established pattern in this file. CI green across all three OSes. Thanks @hongqitai.


Generated by Claude Code

@Hmbown Hmbown merged commit 9988471 into Hmbown:main Jul 5, 2026
14 checks passed
@hongqitai hongqitai deleted the test/env-conflict branch July 5, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants